Skip to content

[pull] master from DataDog:master#29

Merged
pull[bot] merged 3 commits into
ConnectionMaster:masterfrom
DataDog:master
Jul 24, 2025
Merged

[pull] master from DataDog:master#29
pull[bot] merged 3 commits into
ConnectionMaster:masterfrom
DataDog:master

Conversation

@pull

@pull pull Bot commented Jul 24, 2025

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.3)

Can you help keep this open source service alive? 💖 Please sponsor : )

rdesgroppes and others added 3 commits July 23, 2025 21:16
This removes a special case where `pymqi` was depended on by all target
platforms (including macOS on x86_64/AMD64) *except macOS on
AArch64/ARM64*.

There doesn't seem to be a compelling reason for keeping such an ad hoc
exclusion since `pymqi` 1.12.11 basically consists in an installer that
extracts a source tarball (https://pypi.org/project/pymqi/#files) and
compiles it for the _effective_ platform, in place.

In other words, what works for `macosx_10_12_x86_64` should also work
for `macosx_11_0_arm64`.

Moreover, `pymqi` is declared as an **optional** project dependency for
both "IBM ACE" and "IBM MQ", which already offers some leverage since
the dependency is _not installed unless explicitly qualified_:
- https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies
- https://pydevtools.com/handbook/explanation/what-are-optional-dependencies-and-dependency-groups/#optional-dependencies-end-user-features

Should unforeseen consequences happen despite above cautions, then
further actions may be considered (alternatively to a trivial rollback):
1. either drop the dependency at all for macOS where not needed (that is
   on all macOS architectures),
2. and/or bump IBM MQ deliverables to a version that better accomodates
   the AArch64/ARM64 architecture on macOS: #20645.
* Fail config validation if templates are missing.

Along the way refactor how we search for the templates

* changelog
@pull pull Bot locked and limited conversation to collaborators Jul 24, 2025
@pull pull Bot added the ⤵️ pull label Jul 24, 2025
@pull pull Bot merged commit e695023 into ConnectionMaster:master Jul 24, 2025
@pull pull Bot had a problem deploying to typo-squatting-release July 24, 2025 03:59 Failure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants